Skip to content

[Dashboard] Add Media URI to token page #5088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

[Dashboard] Add Media URI to token page #5088

merged 1 commit into from
Oct 21, 2024

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 20, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR adds a new section to display the media URI of an NFT on the TokenIdPage. It includes a button to copy the media URI and a link to view the media in a new tab.

Detailed summary

  • Added a conditional rendering block for nft.metadata.image.
  • Introduced a GridItem for displaying the media URI label.
  • Added a CopyTextButton to copy the media URI.
  • Included a button with a link to open the media URI in a new tab.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 1:54pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 21, 2024 1:54pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 21, 2024 1:54pm
wallet-ui ⬜️ Skipped (Inspect) Oct 21, 2024 1:54pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 20, 2024 04:11 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 20, 2024 04:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 20, 2024 04:11 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d59ab13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@kien-ngo kien-ngo marked this pull request as ready for review October 20, 2024 04:11
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 20, 2024
@kien-ngo Graphite App
Copy link
Contributor Author

kien-ngo commented Oct 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (221f95b) to head (d59ab13).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5088   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1059     1059           
  Lines       54754    54754           
  Branches     3957     3957           
=======================================
  Hits        24804    24804           
  Misses      29259    29259           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 221f95b
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@kien-ngo kien-ngo force-pushed the kien/add-media-uri-to-token-page branch from 9e1a2be to 59525cc Compare October 20, 2024 04:14
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 20, 2024 04:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 20, 2024 04:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 20, 2024 04:14 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 3.5 s (-3.5% 🔽) 4.3 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 8.5 s (+8.17% 🔺) 10.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 186 ms (+51.48% 🔺) 283 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 51 ms (-13.87% 🔽) 61 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 472 ms (-49.32% 🔽) 819 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024 •
edited by MananTank
Loading

Merge activity

@kien-ngo
[Dashboard] Add Media URI to token page (#5088)
d59ab13 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `TokenIdPage` component by adding a section to display the media URI of an NFT, including a button to copy the URI and a link to view it externally.

### Detailed summary
- Added a conditional rendering block to display the media URI if `nft.metadata.image` exists.
- Included a `GridItem` for the "Media URI" heading.
- Added a `CopyTextButton` to copy the media URI.
- Added a button with a link to the media URI, featuring an `ExternalLinkIcon`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the kien/add-media-uri-to-token-page branch from 59525cc to d59ab13 Compare October 21, 2024 13:44
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 21, 2024 13:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 21, 2024 13:44 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 21, 2024 13:44 Inactive
@graphite-app graphite-app bot merged commit d59ab13 into main Oct 21, 2024
33 checks passed
@vercel vercel bot temporarily deployed to Production – docs-v2 October 21, 2024 13:54 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 21, 2024 13:54 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 21, 2024 13:54 Inactive
@graphite-app graphite-app bot deleted the kien/add-media-uri-to-token-page branch October 21, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kien-ngo @MananTank